Single Node deployment with bootstrap-in-place #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eranco74
force-pushed
the
bootstrap-in-place-go-mod
branch
5 times, most recently
from
368e466 to
b7f9fea
Compare
Contributor
Author
|
/retest |
Contributor
|
/test e2e-aws |
Contributor
|
/test e2e-upgrade |
4 similar comments
Contributor
|
/test e2e-upgrade |
Contributor
|
/test e2e-upgrade |
Contributor
|
/test e2e-upgrade |
Contributor
|
/test e2e-upgrade |
Contributor
|
/retest |
|
Ship it :) |
eranco74
changed the title
eranco74
force-pushed
the
bootstrap-in-place-go-mod
branch
from
b7f9fea to
c285d5f
Compare
Contributor
Author
|
/test e2e-aws |
eranco74
force-pushed
the
bootstrap-in-place-go-mod
branch
from
c285d5f to
f03175b
Compare
sttts
reviewed
Jan 21, 2021
|
|
||
| return false, nil | ||
| }, apiContext.Done()) | ||
| if err != nil { |
Contributor
There was a problem hiding this comment.
these changes should be squashed into first commit
Contributor
|
/hold until master reopen for 4.8. /approve |
openshift-ci-robot
added
do-not-merge/hold
in case required-pods="" (this is the case when running bootstrap-in-place) cluster-bootstrap may fail to publish an event in case kube-apiserver isn't up yet. This should solve the problem by ensuring the kube-apiserver is available
This means that we fail to create some manifests
Use fcct for creating the master ignition Signed-off-by: Eran Cohen <eran@stratoscale.com>
eranco74
force-pushed
the
bootstrap-in-place-go-mod
branch
from
f03175b to
cf4ffde
Compare
Contributor
Author
|
/test e2e-upgrade |
1 similar comment
Contributor
Author
|
/test e2e-upgrade |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest |
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eranco74, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding bootstrap-in-place functionality
Add a new entrypoint
--bootstrap-in-placewhich enrich the masterIgnition with control plane static pods manifests and all required
resources, including the etcd database.
cluster-bootstrapnormally waits for a list of required pods to beready. These pods are expected to start running on the control plane
nodes when the bootstrap and control plane run in parallel. That is
not possible when bootstrapping in place, so when
cluster-bootstrapruns with the
--bootstrap-in-placeoption it should only apply themanifests and then tear down the control plane.
If
cluster-bootstrapfails to apply some of the manifests, it shouldreturn an error.